Localise character count component#1565
Merged
Merged
Conversation
40 tasks
colinrotherham
force-pushed
the
component-config-validation
branch
from
71d8f2f to
415f553
Compare
colinrotherham
changed the base branch from
component-config-validation
to
component-form-inputs
colinrotherham
force-pushed
the
component-form-inputs
branch
from
b741de6 to
8d31b01
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
f7c9f07 to
9bc97af
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
from
8d31b01 to
1404bfd
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
9bc97af to
c96b3fd
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
from
1404bfd to
1894244
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
c96b3fd to
8f6afe3
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
from
1894244 to
d5b5244
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
8f6afe3 to
07adb72
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
from
d5b5244 to
5c61bfb
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
07adb72 to
0092409
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
from
5c61bfb to
f05f3d4
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
0092409 to
935f481
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
2 times, most recently
from
34919b2 to
3c583e3
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
935f481 to
3aac68d
Compare
colinrotherham
force-pushed
the
component-form-inputs
branch
from
3c583e3 to
374bcbc
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
3aac68d to
b48dc8a
Compare
colinrotherham
commented
Sep 24, 2025
sarawilcox
moved this from Needs review
to Ready to release
in Service Manual Sprint Board
colinrotherham
force-pushed
the
component-form-inputs
branch
from
ad0a5fa to
33fa97a
Compare
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
b4b6675 to
ba85dc1
Compare
The intersection of browsers that support ES6 modules (and therefore run our JavaScript) but do not support `Intl.PluralRules` is relatively small: - Safari 10.3 - 12.5 on iOS - Safari 10.1 - 12.1 on macOS - Edge 16-18 - Chrome 61-62 - Opera 48-49 These browsers represent a tiny percentage of users and do not justify the overhead of including the extra JavaScript to implement the fallback logic, so let’s remove it. These browsers will instead fall back to the ‘other’ translation. For example, when using the Character Count in English it will display ‘You have 1 characters remaining’ rather than the singular translation ‘You have 1 character remaining’.
colinrotherham
force-pushed
the
component-character-count-localise
branch
from
ba85dc1 to
16a9e1f
Compare
Contributor
Author
|
@anandamaryon1 Good to go with the changelog entry? As discussed, I've also removed the We added this to align with GOV.UK Frontend in #1567 but we prefer it wider |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds character count localisation by porting these features from GOV.UK Frontend:
Backwards compatibility has been maintained with v10.x in 6be936f
Translated examples
I've added a new Translated examples page with Welsh examples for
maxlengthandmaxwordsChecklist