Fix description of namePrefix for date input

[frankieroberto]

The description of how the namePrefix is out of date, as in #994 we updated it to use square brackets instead of hyphens, for easier use with Express.js based servers (eg the NHS Prototype kit).

[frankieroberto]

@colinrotherham @anandamaryon1 I've updated this description again, whaddya think?

[sarawilcox]

Hi @colinrotherham , is there a typo here? "This is used to in the name attribute to group ..."

[colinrotherham]

@sarawilcox Yeah there is, do you mind catching up with the review thread?

[sarawilcox]

I'm afraid I'm not understanding this very well, @colinrotherham . Maybe we can discuss with @anandamaryon1 at PR review meeting tomorrow.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[frankieroberto]

@sarawilcox I’ve fixed the typo 🤦, thanks.

The short story is that in #994 we (well I) updated the date input component so that the name attributes use the format dateOfBirth[day] instead of dateOfBirth-day as part of a breaking change release, in order to make them a lot easier to use in the prototype kit - but I forgot to update the description in the Nunjucks macro options.

[frankieroberto]

@anandamaryon1 @colinrotherham could you check this correction to the namePrefix description makes sense to you, and if so approve it?

I can stick an issue on the backlog for a future debate about whether to rename/alias it from namePrefix or not.

I don’t think this needs a changelog entry as it’s purely a documentation wording change, but happy to add one if you think otherwise?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[frankieroberto]

@colinrotherham created the issue at #1674.

Ok to approve this now?