Skip to content

Uplift GOV.UK Frontend password input component#1574

Merged
colinrotherham merged 4 commits into
mainfrom
component-password-input
Nov 12, 2025
Merged

Uplift GOV.UK Frontend password input component#1574
colinrotherham merged 4 commits into
mainfrom
component-password-input

Conversation

@colinrotherham
Copy link
Copy Markdown
Contributor

@colinrotherham colinrotherham commented Sep 12, 2025 •
edited by anandamaryon1
Loading

Description

This PR adds the password input component from GOV.UK Frontend

Mostly to demonstrate afterInput in #1561 but using small buttons from #1643

Password input tablet

Checklist

@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 12, 2025 08:24 Inactive
@paulrobertlloyd
Copy link
Copy Markdown
Contributor

paulrobertlloyd commented Sep 15, 2025

Is the point at which we add a --small modifier for buttons, that just happen to have the same height as inputs 🙏

@colinrotherham
Copy link
Copy Markdown
Contributor Author

colinrotherham commented Sep 15, 2025 •
edited
Loading

Is the point at which we add a --small modifier for buttons, that just happen to have the same height as inputs 🙏

Yeah I'm just hoping someone has solved this already 😉

@colinrotherham colinrotherham force-pushed the component-character-count-localise branch from 8c08970 to 48e249d Compare September 15, 2025 16:29
@colinrotherham colinrotherham force-pushed the component-password-input branch from 722bdd4 to c5e0c4f Compare September 15, 2025 16:30
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 15, 2025 16:31 Inactive
@colinrotherham colinrotherham force-pushed the component-password-input branch from c5e0c4f to 62c32c6 Compare September 15, 2025 17:38
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 15, 2025 17:38 Inactive
@colinrotherham colinrotherham force-pushed the component-password-input branch from 62c32c6 to 167ff8e Compare September 15, 2025 18:02
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 15, 2025 18:02 Inactive
@colinrotherham colinrotherham force-pushed the component-character-count-localise branch from 14870ea to 25c8f88 Compare September 16, 2025 07:27
@colinrotherham colinrotherham force-pushed the component-password-input branch from 167ff8e to ae0cd1b Compare September 16, 2025 07:27
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 16, 2025 07:28 Inactive
@colinrotherham colinrotherham force-pushed the component-character-count-localise branch from 25c8f88 to d046022 Compare September 16, 2025 08:39
@colinrotherham colinrotherham force-pushed the component-password-input branch from ae0cd1b to 8dfddba Compare September 16, 2025 08:39
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 16, 2025 08:40 Inactive
@colinrotherham colinrotherham force-pushed the component-character-count-localise branch from d046022 to f71dc00 Compare September 19, 2025 12:06
@colinrotherham colinrotherham force-pushed the component-password-input branch from 8dfddba to 7f8dada Compare September 19, 2025 12:23
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 September 19, 2025 12:23 Inactive
@paulrobertlloyd paulrobertlloyd mentioned this pull request Sep 20, 2025
Open
3 tasks
@anandamaryon1 anandamaryon1 mentioned this pull request Sep 24, 2025
Open
40 tasks
@anandamaryon1 anandamaryon1 added this to the v10.2.0 milestone Sep 30, 2025
@colinrotherham colinrotherham force-pushed the component-password-input branch from 7f8dada to ce9b2bb Compare October 2, 2025 15:28
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 October 2, 2025 15:28 Inactive
@nhsuk nhsuk deleted a comment from gitguardian Bot Oct 2, 2025
@colinrotherham colinrotherham force-pushed the component-character-count-localise branch 2 times, most recently from ba85dc1 to 16a9e1f Compare October 7, 2025 13:44
@colinrotherham colinrotherham force-pushed the component-password-input branch from ce9b2bb to 72ace29 Compare October 8, 2025 07:08
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 October 8, 2025 07:09 Inactive
Base automatically changed from component-character-count-localise to main October 8, 2025 08:18
@colinrotherham colinrotherham force-pushed the component-password-input branch from fd48399 to 2bd822d Compare October 29, 2025 16:51
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 October 29, 2025 16:51 Inactive
@colinrotherham colinrotherham force-pushed the small-buttons branch 2 times, most recently from c6567fe to 94a46cd Compare October 31, 2025 12:25
@colinrotherham colinrotherham force-pushed the component-password-input branch from 2bd822d to 0b74caa Compare October 31, 2025 12:36
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 October 31, 2025 12:37 Inactive
@colinrotherham colinrotherham force-pushed the component-password-input branch from 0b74caa to c60e461 Compare October 31, 2025 17:58
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 October 31, 2025 17:58 Inactive
@colinrotherham colinrotherham force-pushed the component-password-input branch from c60e461 to 6eb0fde Compare November 6, 2025 14:28
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 November 6, 2025 14:28 Inactive
@colinrotherham colinrotherham force-pushed the component-password-input branch from 6eb0fde to 05ebc4a Compare November 10, 2025 08:07
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 November 10, 2025 08:08 Inactive
Base automatically changed from small-buttons to main November 10, 2025 17:15
@colinrotherham colinrotherham force-pushed the component-password-input branch from 05ebc4a to 81e2cff Compare November 11, 2025 16:31
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 November 11, 2025 16:31 Inactive
@colinrotherham colinrotherham temporarily deployed to nhsuk-frontend-pr-1574 November 11, 2025 16:33 Inactive
@colinrotherham colinrotherham force-pushed the component-password-input branch from d922738 to c6e0021 Compare November 11, 2025 16:43
@colinrotherham
Copy link
Copy Markdown
Contributor Author

colinrotherham commented Nov 11, 2025

@anandamaryon1 Changelog added and reference images updated

This one's ready to go

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

anandamaryon1
anandamaryon1 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@anandamaryon1 anandamaryon1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser tested, no issues found.

Tested with VoiceOver and NVDA and TalkBack, but cannot test JAWS, VoiceOver on iOS or Dragon via browserstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandamaryon1 anandamaryon1 anandamaryon1 approved these changes

Assignees

@colinrotherham colinrotherham

Labels

Enhancement: feature request New feature or request password input

Projects

Service Manual Sprint Board
Status: Done - 2025

Milestone

v10.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@colinrotherham @paulrobertlloyd @anandamaryon1