Fix to previous javascript filename in CHANGELOG#1575
Merged
Conversation
We made a small mistake in the v10 upgrade guide by saying that the javascripts path in the templates used to be `nhsuk-frontend.min.js` but it actually used to be `nhsuk.min.js`. We've also realised that the path prefix is not necessarily `/javascripts/` but can vary depending on your setup (eg the NHS prototype kit uses `/nhsuk-frontend/`). So this makes that clearer by using `<JAVASCRIPTS-PATH>` to hopefully make it clear that that bit isn't part of the upgrade guidance.
|
colinrotherham
approved these changes
Sep 12, 2025
Contributor
colinrotherham
left a comment
colinrotherham
left a comment
There was a problem hiding this comment.
Thanks @frankieroberto, this is definitely clearer
For context, we (wrongly) assumed this change was completed in an earlier step to update file paths:
If you are using the precompiled file in the npm package at
node_modules/nhsuk-frontend/dist/nhsuk.min.js, update this path tonode_modules/nhsuk-frontend/dist/nhsuk/nhsuk-frontend.min.js
Much better now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made a small mistake in the v10 upgrade guide by saying that the javascripts path in the templates used to be
nhsuk-frontend.min.jsbut it actually used to benhsuk.min.js.We've also realised that the path prefix is not necessarily
/javascripts/but can vary depending on your setup (eg the NHS prototype kit uses/nhsuk-frontend/). So this makes that clearer by using<JAVASCRIPTS-PATH>to hopefully make it clear that that bit isn't part of the upgrade guidance.