[v10] Refactor character count method to reduce repeated updates#1892
Merged
Conversation
colinrotherham
added
🐛 bug
colinrotherham
force-pushed
the
puppeteer-tests
branch
from
a67b837 to
c5b2ffd
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
c2f3d2c to
a153f0e
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
a153f0e to
48d8f00
Compare
colinrotherham
force-pushed
the
puppeteer-tests
branch
from
c5b2ffd to
878a967
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
48d8f00 to
a91fa34
Compare
colinrotherham
changed the title
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
a91fa34 to
93126fa
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
93126fa to
bd0c90d
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
bd0c90d to
b409382
Compare
colinrotherham
changed the base branch from
support/10.x
to
component-config-functions
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
b409382 to
c2c1c8e
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
c2c1c8e to
5f27509
Compare
MatMoore
approved these changes
May 5, 2026
Contributor
MatMoore
left a comment
MatMoore
left a comment
There was a problem hiding this comment.
LGTM, only thing I'm not sure about it is why we need to add deprecated methods in?
| this.length = text.length | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
can we remove the deprecated methods again in this PR? Seems like as long as there's a replacement we could update the tests to use that...
Contributor
Author
There was a problem hiding this comment.
We can remove them in v11
It's unlikely, but teams might be using them in v10.x so it would be a breaking change
colinrotherham
force-pushed
the
component-config-functions
branch
from
3617004 to
cdb8624
Compare
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
5f27509 to
2d10de4
Compare
See: alphagov/govuk-frontend#5071 Co-authored-by: beeps <hi+github@berly.kim>
colinrotherham
force-pushed
the
fix-character-count-repetition
branch
from
2d10de4 to
f617fed
Compare
|
github-project-automation
Bot
moved this from Needs review
to Ready to release
in Service Manual Sprint Board
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uplifts alphagov/govuk-frontend#6449 from GOV.UK Frontend v6.0.0 to improve the character count
Our JavaScript API is public by default (we publish types) so I've added 7b8cd78 and d66c040 for compatibility
Credit to @querkmachine for the original changes
Unblocks #1619
Checklist