Skip to content

Fix clean task Error: ENOTEMPTY: directory not empty, rmdir #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinrotherham merged 2 commits into from
Apr 30, 2026
Merged

Fix clean task Error: ENOTEMPTY: directory not empty, rmdir #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cdb6d2
Fix clean task `Error: ENOTEMPTY: directory not empty, rmdir`
colinrotherham Apr 29, 2026
f16aead
Only build components with templates
colinrotherham Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"scripts": {
"install:playwright": "playwright install chromium --with-deps --only-shell",
"install:puppeteer": "puppeteer browsers install",
"preclean": "del-cli dist",
"preclean": "del-cli dist/*",
"clean": "npm run clean --if-present --workspaces",
"postclean": "tsc --build --clean",
"build": "npm run build --if-present --workspaces",
Expand Down
2 changes: 1 addition & 1 deletion packages/nhsuk-frontend-review/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "NHS.UK frontend review app",
"license": "MIT",
"scripts": {
"clean": "del-cli dist",
"clean": "del-cli dist/*",
"postclean": "tsc --build --clean",
"build": "gulp build --color",
"serve": "gulp serve --color",
Expand Down
2 changes: 1 addition & 1 deletion packages/nhsuk-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"!**/*.test.*"
],
"scripts": {
"clean": "del-cli dist",
"clean": "del-cli dist/nhsuk/*",
Copy link
Copy Markdown
Contributor Author

@colinrotherham colinrotherham Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The del package doesn't set maxRetries when removing files or directories

But updating the glob dist → dist/nhsuk/* splits out multiple paths to delete which appears to solve the problem (i.e. smaller batched deletes rather than one large delete)

"postclean": "tsc --build --clean",
"build": "gulp build --color",
"watch": "gulp watch --color",
Expand Down
6 changes: 3 additions & 3 deletions shared/lib/components.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { readFileSync } from 'node:fs'
import { basename, join } from 'node:path'
import { basename, dirname, join } from 'node:path'

import { paths } from '@nhsuk/frontend-config'

Expand Down Expand Up @@ -76,12 +76,12 @@ export async function loadAll() {
* Get component names
*/
export function getNames() {
const listing = files.getDirectories('nhsuk/components', {
const listing = files.getListing('nhsuk/components/*/template.njk', {
Copy link
Copy Markdown
Contributor Author

@colinrotherham colinrotherham Apr 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes an issue where switching branches would leave empty directories behind, which then causes errors when trying to run file operations or build tasks on them

E.g. packages/nhsuk-frontend/src/nhsuk/components/search-input

cwd: join(paths.pkg, 'src')
})

// Use directory names only
return listing.map((directoryPath) => basename(directoryPath)).sort()
return listing.map((directoryPath) => basename(dirname(directoryPath))).sort()
}

/**
Expand Down
Loading