[SPIKE] Add NHS.UK frontend code autocomplete #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
commented
Nov 11, 2025
Comment on lines
+248
to
+252
| app.use((err, req, res, next) => { | ||
| if (res.headersSent) { | ||
| return next(err) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I've added this as a little example of why using types can be good
Error middleware checks in Express.js use Function.length to check for 4x calling arguments
i.e. We've missed the next param here
colinrotherham
force-pushed
the
code-autocomplete
branch
from
0a12ab0 to
359810b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the TypeScript compiler to automatically discover code autocomplete suggestions etc
Seems a shame not to use the published type declarations from NHS.UK frontend package
E.g. Moving the
initAll()import from HTML to the main.js fileChecklist