fixed wrong get indicator label and added reverse 1d array to ctrl se… #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch Signed-off-by: Jens-Peter Tuppatsch <[email protected]>
jasonmreding
reviewed
Apr 8, 2025
... Server Support New/gRPC Scripting Tools/Oneof API/Accessor Helpers/GenOneOf_Get_Accessor.vi
Show resolved
Hide resolved
…onOneOf_Get-Set_Accessor throw error if control-indicator not found Signed-off-by: Jens-Peter Tuppatsch <[email protected]>
Contributor
Author
|
I didn't know about the tabbing order, I learned that. Thanks |
jasonmreding
approved these changes
Apr 21, 2025
Collaborator
|
@pettaa123 It appears one or all of the VIs from this PR were saved in LV 2020 rather than LV 2019. |
jasonmreding
requested changes
Apr 23, 2025
Collaborator
jasonmreding
left a comment
jasonmreding
left a comment
There was a problem hiding this comment.
Please resubmit VIs saved in LV 2019.
…arch Signed-off-by: Jens-Peter Tuppatsch <[email protected]>
…onOneOf_Get-Set_Accessor throw error if control-indicator not found Signed-off-by: Jens-Peter Tuppatsch <[email protected]>
…or' of https://github.com/pettaa123/grpc-labview into correct_get_accessor_label_ident_in_genoneof_get_accessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arch
GetOneOf_Get_Accessor.vi search for wrong label Get_Indicator, instead of Get_Val as in OneOfTemplate.lvclass:GetTemplate.vi
This worked since Get_Val was always last in ctrl array.
Because of this I added a reverse 1d array to ctrl array, since Get_Val and Set_Val appear to be always last.