Merged
Conversation
Signed-off-by: Sacheta-NI <sacheta@ni.com>
Signed-off-by: Sacheta-NI <sacheta@ni.com>
Signed-off-by: Sacheta . <sacheta@ni.com>
yash-ni
reviewed
Apr 22, 2025
Collaborator
|
What testing has been done as part of this change? |
jasonmreding
requested changes
Apr 23, 2025
Collaborator
jasonmreding
left a comment
jasonmreding
left a comment
There was a problem hiding this comment.
Waiting for changes to be reverted or confirmation via testing that serialization from a LV client for an array of messages works.
Signed-off-by: Sacheta . <sacheta@ni.com>
Signed-off-by: Sacheta-NI <sacheta@emerson.com>
…isabled Signed-off-by: Sacheta-NI <sacheta@ni.com>
…nto grpc_upgrade_62_windows Merging changes from main branch
Signed-off-by: Sacheta-NI <sacheta@ni.com>
Collaborator
Can you elaborate on this a bit? Is this an issue with the lookup path for the grpc library on Linux? |
jasonmreding
approved these changes
Apr 29, 2025
yash-ni
approved these changes
Apr 29, 2025
Signed-off-by: Sacheta . <sacheta@ni.com>
Signed-off-by: Sacheta-NI <sacheta@emerson.com>
CPattar-NI
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded the gRPC submodule from v1.44 to v1.62.0 to address multiple security vulnerabilities (CVE-2023-44487, CVE-2023-4785, CVE-2023-33953).
Temporarily disabled LVMessageEfficient due to a breaking change in the updated Protobuf library:
RepeatedField no longer supports the char type, which was used in the LVMessageEfficient class.
For now, the system falls back to using the LVMessage class. A permanent fix will be addressed separately.
Testing
Windows (32-bit and 64-bit):
Verified that LVMessageEfficient is properly disabled through feature toggle testing.
Linux testing has not been performed. During early validation only, we observed that several code generation VIs use hardcoded Windows-style paths instead of building paths dynamically with the "Build Path" node. These hardcoded paths are incompatible with Linux It must not be working even currently. Path corrections and Linux validation will be addressed separately.