Conversation
bkeryan
commented
Jul 28, 2025
bkeryan
commented
Jul 28, 2025
bkeryan
commented
Jul 28, 2025
bkeryan
commented
Jul 28, 2025
bkeryan
commented
Jul 28, 2025
jasonmreding
approved these changes
Jul 29, 2025
This was referenced Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update
SetLVStringandGetLVStringto convert to/from UTF-8 usingConvertSystemStringToUTF8andConvertUTF8StringToSystem.Add two test cases:
Test_HelloWorld_Internationalization.vitests the HelloWorld client+server with internationalized strings. Unfortunately, this test still passes without the fix because both the client and server use the same incorrect string encoding.Test_HelloWorld_Utf8Encoding.vipacks ahelloworld.HelloRequestto Any, searches for the UTF-8 encoded string, and unpacks it and compares the result. This test fails without the fix.Why should this Pull Request be merged?
Closes #461
What testing has been done?
Ran new tests on LabVIEW 2019.