Update public api and test support

packages/eslint-config-angular/i18n-attributes-ignore.js → packages/eslint-config-angular/options.js

@@ -60,8 +60,8 @@ const ignoreAttributes = {
         'matTooltipClass',
     ]
 };
+ignoreAttributes.all = Object.values(ignoreAttributes).flat();
 
 module.exports = {
-    ...ignoreAttributes,
-    all: [...ignoreAttributes.nimble, ...ignoreAttributes.systemlink, ...ignoreAttributes.jqx, ...ignoreAttributes.material]
+    ignoreAttributes
 };

packages/eslint-config-angular/template.js

@@ -1,4 +1,4 @@
-const ignoreAttributes = require('./i18n-attributes-ignore');
+const { ignoreAttributes } = require('./options');
 
 module.exports = {
     extends: [
@@ -94,5 +94,18 @@ module.exports = {
             Providing a `trackBy` function in `ngFor` loops can improve performance in specific cases where Angular can't track references, but it's overkill to require it for every `ngFor` so this rule is disabled.
         */
         '@angular-eslint/template/use-track-by-function': 'off'
-    }
+    },
+    overrides: [
+        {
+            // Ignore inline templates in tests using the inline template naming convention
+            // See naming details: https://github.com/angular-eslint/angular-eslint/releases/tag/v14.0.0
+            files: ['*.spec.ts*.html'],
+            rules: {
+                /*
+                    Tests often define helper components that don't need to be marked for i18n.
+                */
+                '@angular-eslint/template/i18n': 'off'
+            }
+        },
+    ]
 };

tests/angular/.eslintrc.js

@@ -1,5 +1,6 @@
 // Test TypeScript and templates together to process inline templates.
 module.exports = {
+    ignorePatterns: ['*.js'],
     overrides: [{
         extends: [
             '@ni/eslint-config-angular',

tests/angular/custom-ignore-attributes/.eslintrc.js

@@ -0,0 +1,21 @@
+const {ignoreAttributes} = require('@ni/eslint-config-angular/options');
+
+module.exports = {
+    overrides: [{
+        files: ['*.html'],
+        rules: {
+            '@angular-eslint/template/i18n': [
+                'error',
+                {
+                    checkId: false,
+                    ignoreAttributes: [...ignoreAttributes.all, 'custom-field']
+                }
+            ],
+        }
+    }, {
+        files: ['*.spec.ts*.html'],
+        rules: {
+            '@angular-eslint/template/i18n': 'off'
+        }
+    }]
+};

tests/angular/custom-ignore-attributes/index.html

@@ -0,0 +1,2 @@
+<!-- Angular Template Custom Ignore Attributes Test -->
+<span i18n custom-field="test-custom-field">Hello {{name}}</span>

tests/angular/custom-ignore-attributes/index.spec.ts

@@ -0,0 +1,24 @@
+// Angular test spec smoke test
+import { Component, Input, ViewChild } from '@angular/core';
+import { ComponentFixture } from '@angular/core/testing';
+
+@Component({
+    template: '<div custom-attribute="i18n-should-be-ignored-in-test"></div>'
+})
+class MyComponent {
+    @Input() public attr = false;
+    @ViewChild('div') public div: HTMLDivElement;
+    public myMethod(): void {}
+}
+
+describe('MyComponent', () => {
+    let hostComponent: MyComponent;
+    let fixture: ComponentFixture<MyComponent>;
+
+    it('should have a div', async () => {
+        await fixture.whenStable();
+
+        expect(hostComponent.div).toBeDefined();
+        expect(hostComponent.myMethod).not.toHaveBeenCalled();
+    });
+});

tests/angular/custom-ignore-attributes/index.ts

@@ -0,0 +1,15 @@
+// Angular TypeScript and Inline Template Smoke Test
+import { Component, Input } from '@angular/core';
+
+@Component({
+    selector: 'app-root',
+    template: '<span i18n custom-field="test-custom-field">Hello {{name}}</span>!',
+    styles: [`
+        span {
+            font-weight: bold;
+        }
+    `]
+})
+export class AppComponent {
+    @Input() public name = 'Angular';
+}

tests/angular/index.spec.ts

@@ -3,7 +3,7 @@ import { Component, Input, ViewChild } from '@angular/core';
 import { ComponentFixture } from '@angular/core/testing';
 
 @Component({
-    template: '<div [(attr)] = true></div>'
+    template: '<div custom-attribute="i18n-should-be-ignored-in-test">missing i18n should be ignored</div>'
 })
 class MyComponent {
     @Input() public attr = false;

tests/angular/tsconfig.json

@@ -2,8 +2,5 @@
     "compilerOptions": {
         "experimentalDecorators": true
     },
-    "files": [
-        "index.ts",
-        "index.spec.ts"
-    ]
+    "include": ["."]
 }