Ensure proper auditd/logging permissions following reboot#60
Merged
AlexHearnNI merged 5 commits intoni:masterfrom Mar 6, 2025
Merged
Ensure proper auditd/logging permissions following reboot#60AlexHearnNI merged 5 commits intoni:masterfrom
AlexHearnNI merged 5 commits intoni:masterfrom
Conversation
eli-engelhardt
requested review from
a team,
AlexHearnNI and
amstewart
as code owners
amstewart
requested changes
Feb 28, 2025
Collaborator
amstewart
left a comment
amstewart
left a comment
There was a problem hiding this comment.
It's a little unclear to me what this commit is supposed to do. It seems like it's doing a few things, and the commit message isn't helpful.
Could you break this up into its component parts and make sure that all the necessary context about the change is in the commits? If part of this is a bug fix, the commit messages at least need to explain the bug and the fix.
- Added the `textwrap` module to clean up indentations in template scripts. This change improves the readability and consistency of the script formatting. - Remove sudo group from ownership of a privileged file Signed-off-by: Eli Engelhardt <eli.engelhardt@emerson.com>
eli-engelhardt
force-pushed
the
fix_nilrt_verify_fail
branch
from
6711c09 to
78b1573
Compare
Moved the initialization of `auditd_config_file` to occur after the potential installation of the auditd package. This change ensures that the auditd.conf is correctly populated. Previously, the file could be initialized as an empty string if it didn't exist, leading to the entire file being overwritten with an empty string. Signed-off-by: Eli Engelhardt <eli.engelhardt@emerson.com>
Added a script `/etc/init.d/set_log_permissions.sh` to ensure that the permissions of the `/var/log` directory are correctly set and persist between system reboots. This change addresses the issue of incorrect permissions on the log directory after reboot. Signed-off-by: Eli Engelhardt <eli.engelhardt@emerson.com>
The ownership for privileged files such as '/etc/syslog-ng/syslog-ng.conf' should stay as the default ownership of root:root. Signed-off-by: Eli Engelhardt <eli.engelhardt@emerson.com>
amstewart
approved these changes
Mar 5, 2025
AlexHearnNI
reviewed
Mar 6, 2025
Signed-off-by: Eli Engelhardt <eli.engelhardt@emerson.com>
Collaborator
|
/azp run ni-nilrt-snac-pr |
1 similar comment
Contributor
Author
|
/azp run ni-nilrt-snac-pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Justification
Bug 3033025: nilrt-snac verify fails with error code 129. The verification steps that are failing after reboot:
Testing
Tested locally on clean reimaged VM.
Procedure