Add snac configuration file with commented out list of modules and update Makefile for installation#75
Conversation
texasaggie97
requested review from
a team,
AlexHearnNI and
amstewart
as code owners
| # | ||
| # Example: To disable a module, uncomment the line and set to 'disabled'. | ||
| # | ||
| # ntp = disabled # NTP time synchronization |
There was a problem hiding this comment.
The comment at the beginning is hard to notice. Since you already tell them above to set it to disabled, why not have this uncommented and set to enabled? That way the change the user must do is simpler.
There was a problem hiding this comment.
I didn't want to imply that you have to explicitly enable each module. If I put all of them enabled, that is what it will imply. At least that is how I would interpret it.
Plus I thought most conf files have the opposite of the default but commented out so that all you do is remove the '#'.
There was a problem hiding this comment.
I guess I didn't make my "not an expert" status explicit. If that's how most config files in Linux do it, by all means.
amstewart
left a comment
amstewart
left a comment
There was a problem hiding this comment.
Sorry, now that I'm looking at the diff, I've convinced myself / remembered that there is a more correct way to distribute this package.
This project's dist package operations (eg. our Makefile) shouldn't be installing things to the sysconf (/etc) locations unless we have to (as in the case of the wireguard configuration.) Instead, the Makefile install and uninstall should place the snac.conf file into the architecture-independent files location, eg.
$(DESTDIR)$(docdir)/$(PACKAGE)/snac.conf.example (installed with mode 0444)
And then, in meta-nilrt, the recipe file should be the copied into the sysconf location with the admins given write-access.
structure and enable module control via config file Signed-off-by: Mark Silva <mark.silva@emerson.com>
Signed-off-by: Mark Silva <mark.silva@emerson.com>
Co-authored-by: Dan Mondrik <dan.mondrik@ni.com> Signed-off-by: Mark Silva <103217450+texasaggie97@users.noreply.github.com>
…date Makefile for installation Signed-off-by: Mark Silva <mark.silva@emerson.com> Review comment - makefile Review comment - conf
texasaggie97
force-pushed
the
dev/texasaggie97/add-snac-conf-file
branch
from
be9aa13 to
245fa64
Compare
|
I had to fix merge issues when rebasing to combine the requested changes. This caused many additional and unwanted changed to be added. I am abandoning this and starting over. |
3 participants
Summary of Changes
snac.conf[modules]sectionMakefileto install to correct locationJustification
AB#3335800
Testing
Built locally and verified file in correct location
Procedure