Do not create the /var/log/nilrt-snac directory#81
Merged
Conversation
Signed-off-by: Mark Silva <mark.silva@emerson.com>
texasaggie97
requested review from
a team,
AlexHearnNI and
amstewart
as code owners
chaitu236
approved these changes
Nov 13, 2025
chaitu236
left a comment
chaitu236
left a comment
There was a problem hiding this comment.
Did a local build of nilrt with this change and it passes now.
amstewart
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We should not create the
/var/log/nilrt-snacdirectory since this breaks the build with a QA issue. The script will create it as needed.Justification
This is breaking the OE build
Testing
PR
Procedure