Skip to content

clamav: Update SNAC config for optional daemon and improved verification #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmondrik merged 1 commit into from
Nov 25, 2025
Merged

clamav: Update SNAC config for optional daemon and improved verification #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions nilrt_snac/_configs/_clamav_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import argparse
import os
import pathlib

from nilrt_snac._configs._base_config import _BaseConfig
Expand All @@ -16,6 +17,7 @@ def __init__(self):
self.clamd_config_path = "/etc/clamav/clamd.conf"
self.freshclam_config_path = "/etc/clamav/freshclam.conf"
self.virus_db_path = "/var/lib/clamav/"
self.resolv_conf_path = "/var/run/resolv.conf"
self.package_names = ["clamav", "clamav-daemon", "clamav-freshclam"]
self._opkg_helper = opkg_helper

Expand All @@ -34,15 +36,21 @@ def verify(self, args: argparse.Namespace) -> bool:
if installed_packages:
print("Verifying clamav configuration...")
valid = True

if self._opkg_helper.is_installed("clamav-freshclam"):
# Check DNS configuration (critical for freshclam)
if not os.path.exists(self.resolv_conf_path) or os.path.getsize(self.resolv_conf_path) == 0:
logger.error(f"DNS not configured: {self.resolv_conf_path} is empty or missing")
logger.error("freshclam will fail without DNS. Configure network/DNS before running freshclam.")
valid = False

# Check clamd configuration file
clamd_config = _ConfigFile(self.clamd_config_path)
if not clamd_config.exists():
logger.error(f"ClamAV daemon config file missing: {self.clamd_config_path}")
valid = False
elif pathlib.Path(self.clamd_config_path).stat().st_size == 0:
logger.error(f"ClamAV daemon config file is empty: {self.clamd_config_path}")
valid = False
# Check clamd configuration file (only if daemon package is installed)
if self._opkg_helper.is_installed("clamav-daemon"):
clamd_config = _ConfigFile(self.clamd_config_path)
if not clamd_config.exists():
logger.info(f"ClamAV daemon config file missing: {self.clamd_config_path}")
elif pathlib.Path(self.clamd_config_path).stat().st_size == 0:
logger.info(f"ClamAV daemon config file is empty: {self.clamd_config_path}")

# Check freshclam configuration file
freshclam_config = _ConfigFile(self.freshclam_config_path)
Expand Down
Loading