Don't need quotes around the value#85
Merged
Conversation
texasaggie97
requested review from
a team,
AlexHearnNI and
amstewart
as code owners
Signed-off-by: Mark Silva <mark.silva@emerson.com>
texasaggie97
force-pushed
the
dev/texasaggie97/persistent-logs-error
branch
from
8fb2fa9 to
cb7980a
Compare
amstewart
previously requested changes
Jan 14, 2026
Signed-off-by: Mark Silva <mark.silva@emerson.com>
texasaggie97
force-pushed
the
dev/texasaggie97/persistent-logs-error
branch
from
cb7980a to
cd07e07
Compare
AlexHearnNI
approved these changes
Jan 21, 2026
amstewart
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Remove double quotes around value when enabling persistent logging
Justification
AB#3698523
nirtcfgadds quotes around the value, and having them here caused two double quotes before and after. This caused an error on boot when the file couldn't be parsed properly.Testing
nilrt-snac configureProcedure