Skip to content

refactor: simplify Observable creation using of() operator in HistoricalQueryHandler#520

Draft
Copilot wants to merge 7 commits intomainfrom
copilot/sub-pr-517-again
Draft

refactor: simplify Observable creation using of() operator in HistoricalQueryHandler#520
Copilot wants to merge 7 commits intomainfrom
copilot/sub-pr-517-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 12, 2025

Pull Request

🤨 Rationale

Addresses feedback from #517 to replace manual Observable construction with RxJS's idiomatic of() operator in HistoricalQueryHandler.ts.

👩‍💻 Implementation

HistoricalQueryHandler.ts:

  • Added of to rxjs imports
  • Replaced manual Observable construction pattern with of(aggregatedResults)
// Before
new Observable<TagHistoryResponse>(subscriber => {
    subscriber.next(aggregatedResults);
    subscriber.complete();
})

// After
of(aggregatedResults)

TagDataSource.ts:

  • Fixed missing closing parenthesis in switchMap call (syntax error from previous commit)

🧪 Testing

  • TypeScript type checking passes
  • ESLint validation passes with no new warnings
  • CodeQL security scan found 0 alerts

✅ Checklist


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

robertMileaNi and others added 6 commits November 12, 2025 15:23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: MileaRobertStefan <58860510+MileaRobertStefan@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on request cancellation logic refactor: simplify Observable creation using of() operator in HistoricalQueryHandler Nov 12, 2025
Base automatically changed from users/rmilea/2025/tagsdatasouce/cancel_request to main November 17, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants