Deep heating dev#166
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Add per-level heating within the atmosphere column
Deep heating dev
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes from Andy to add per-level heating within the atmosphere column. Required step before handling #26.
Key changes in the style/refactoring commit (
beab59c):[deep_heating]under[physics.deep_heating]for consistency. Renamed keys (P_dep→Pmid,sigma_P→Pwid,efficiency→flux_rel,F_total→flux_abs). Replacedactivebool withpower_mode="off"|"rel"|"abs".DeepHeatingParamsstruct: Replaced with flat fields onAtmos_t(deepheat_Pmid,deepheat_Pwid, etc.) matching AGNI's existing pattern.AGNI.jl: Single block with key-presence validation replaces 36 lines of per-fieldhaskeychecks.set_deep_heating!signature: Positional args, input validation with@error/Boolreturn, bar→Pa conversion at call site.calc_fluxes!: Addeddeep::Boolkwarg to control deep heating instead of checking struct field.src/energy.jl:979:deepheatingreferenced but the parameter is nameddeep— will causeUndefVarErrorat runtime.Validation of changes
Tested on Fedora 43, Julia 1.11
Checklist
Relevant people
@Didymos65803
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.