Skip to content

Deep heating dev#166

Closed
Copilot wants to merge 1 commit into
deep-heating-devfrom
copilot/sub-pr-165
Closed

Deep heating dev#166
Copilot wants to merge 1 commit into
deep-heating-devfrom
copilot/sub-pr-165

Conversation

Copilot AI commented Feb 23, 2026

Copy link
Copy Markdown

Description

Changes from Andy to add per-level heating within the atmosphere column. Required step before handling #26.

Key changes in the style/refactoring commit (beab59c):

  • Config restructured: Moved [deep_heating] under [physics.deep_heating] for consistency. Renamed keys (P_depPmid, sigma_PPwid, efficiencyflux_rel, F_totalflux_abs). Replaced active bool with power_mode="off"|"rel"|"abs".
  • Removed DeepHeatingParams struct: Replaced with flat fields on Atmos_t (deepheat_Pmid, deepheat_Pwid, etc.) matching AGNI's existing pattern.
  • Simplified config parsing in AGNI.jl: Single block with key-presence validation replaces 36 lines of per-field haskey checks.
  • set_deep_heating! signature: Positional args, input validation with @error/Bool return, bar→Pa conversion at call site.
  • calc_fluxes!: Added deep::Bool kwarg to control deep heating instead of checking struct field.
  • Version bump: 1.8.6 → 1.8.7
  • Docs: Added Cheng An Hsieh to collaborators page.

⚠️ Known bug in src/energy.jl:979: deepheating referenced but the parameter is named deep — will cause UndefVarError at runtime.

Validation of changes

Tested on Fedora 43, Julia 1.11

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Relevant people

@Didymos65803


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Feb 23, 2026
8 tasks
Copilot AI changed the title [WIP] Add per-level heating within the atmosphere column Deep heating dev Feb 23, 2026
Copilot AI requested a review from nichollsh February 23, 2026 21:05
@nichollsh nichollsh closed this Feb 23, 2026
@nichollsh nichollsh deleted the copilot/sub-pr-165 branch February 27, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants