Allow i18n on add/remove links#82
Open
fredwu wants to merge 1 commit into
Open
Conversation
Owner
nickcharlton
left a comment
nickcharlton
left a comment
There was a problem hiding this comment.
Thanks! Do you have any thoughts on how we could test this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: breaking changes.
The limitation of the current implementation means that the add/remove links cannot be i18n'ed if the resource name also needs translation.
This PR addresses this, although, as a consequence, by default the translation for all links are fixed as seen in the
defaultssection in the yaml files, and individual ones need to be added to them.