Skip to content

support redis-namespace client#10

Open
doits wants to merge 2 commits intonickelser:masterfrom
doits:allow_redis_namespaced
Open

support redis-namespace client#10
doits wants to merge 2 commits intonickelser:masterfrom
doits:allow_redis_namespaced

Conversation

@doits
Copy link

@doits doits commented Nov 16, 2018

redis-namespace is a tiny wrapper around redis-rb that adds support for namespaces. It behaves exactly the same as redis-rb, so it should be supported by this gem. This PR adds support and tests for it.

To init the client you simply do:

ActiveJob::TrafficControl.client = Redis::Namespace.new(:namespace, redis: Redis.new)

Everything seems to work as it should (according to the tests).

@doits
Copy link
Author

doits commented Nov 16, 2018

I just added a commit that does not require redis-namespace gem. So for people that have it installed, it will simply work, but people don't using it don't have to install it.

@doits
Copy link
Author

doits commented Nov 16, 2018

I don't think the test failures relate to my changes.

@doits
Copy link
Author

doits commented Nov 26, 2018

@nickelser do you maybe have some time to look at this? It is a fairly straight forward change the merely adds some compatibility.

@doits
Copy link
Author

doits commented Apr 2, 2019

@nickelser maybe got some time now? or is this gem deprecated for you? If so, I could offer myself as a maintainer (got not big plans, just to keep it running).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant