Support setting false-y values for cache_client#23
Open
danielwestendorf wants to merge 1 commit intonickelser:masterfrom
Open
Support setting false-y values for cache_client#23danielwestendorf wants to merge 1 commit intonickelser:masterfrom
danielwestendorf wants to merge 1 commit intonickelser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given an app that
disabled?functionalityThis gem then prepends every job execution with a file read. This isn't a big deal, but setting
ActiveJob::TrafficControl.cache_client = falsehas no effect, despite the library having support for a false-ycache_client. This is due to usage of||=and the default ofRails.cache.