Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make images selectable #40

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

derneuere
Copy link

This pull request adds the option to select images.

Three new props have been added: 'selectable', 'selectedItems' and 'handleSelection'.

To activate the option use 'selectable'
'selectedItems' is optional. If it is provided, all the tiles will be selected accordingly. If it is not provided, then the component will manage the selected items itself.
'handleSelection' is optional. You can add your own function on select by providing it. Otherwise, the component will handle the selections on its own.

It includes an example component 'SelectablePig' to demonstrate on how to implement selecting images for a parent component. It uses the click handler from #37, to implement selecting multiple images with shift click.

To-Do:

  • make sure implementation understandable for end users
  • replace transform of margin with a box shadow or another command with a lower performance impact
  • add an option to style the checkbox. A html checkbox is not ideal, but I think something like React Custom Checkbox woud be better
  • apply the correct code style

Feedback and discussion will be appreciated. I am not a frontend dev and I probably did a couple of things in the wrong way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant