fix(daemon): preserve server-owned counters on rewrite; wire fired co…#22
Merged
Conversation
…unter Two bookkeeping-counter bugs in the knowledge daemon: 1. Counter clobber. LLM entry rewrites (update_entry / merge_entries / abstract) wrote the model's frontmatter verbatim, overwriting the fired-helpful and reinforced counters the daemon had just bumped on disk. The fired-helpful high-water dedup then froze the loss permanently. The executor is now the single source of truth for the server-owned bookkeeping fields (fired, fired-helpful, last_fired_helpful, reinforced, last_reinforced, last_surfaced, created): on any rewrite that replaces an existing entry it forces those values from the prior on-disk entry onto the proposed body and discards whatever the model emitted. Prose and all other frontmatter stay LLM-owned. 2. Dead `fired` counter. `fired` had no writer (0 on every entry). Priming now calls decay.record_surface() per surfaced entry, which increments `fired` per surface event (not daily-gated) and stamps last_surfaced in one atomic write, so fired-helpful <= fired holds. Adds regression tests for both (executor preservation across update/merge/deprecate/abstract; per-event fired increment; invariant guard). Fix-forward only: no existing knowledge data was modified. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…unter
Two bookkeeping-counter bugs in the knowledge daemon:
Counter clobber. LLM entry rewrites (update_entry / merge_entries / abstract) wrote the model's frontmatter verbatim, overwriting the fired-helpful and reinforced counters the daemon had just bumped on disk. The fired-helpful high-water dedup then froze the loss permanently. The executor is now the single source of truth for the server-owned bookkeeping fields (fired, fired-helpful, last_fired_helpful, reinforced, last_reinforced, last_surfaced, created): on any rewrite that replaces an existing entry it forces those values from the prior on-disk entry onto the proposed body and discards whatever the model emitted. Prose and all other frontmatter stay LLM-owned.
Dead
firedcounter.firedhad no writer (0 on every entry). Priming now calls decay.record_surface() per surfaced entry, which incrementsfiredper surface event (not daily-gated) and stamps last_surfaced in one atomic write, so fired-helpful <= fired holds.Adds regression tests for both (executor preservation across update/merge/deprecate/abstract; per-event fired increment; invariant guard). Fix-forward only: no existing knowledge data was modified.