chore: update renamed options#25
chore: update renamed options#25nicolas-goudry merged 1 commit intonicolas-goudry:mainfrom rhoriguchi:main
Conversation
|
✔️ 4042cc7 - Conventional commits check succeeded. |
nicolas-goudry
left a comment
There was a problem hiding this comment.
Interesting, thanks for your contribution!
I made some comments on your PR that need to be addressed before considering to merge.
Also, be aware that I’ll hold up on releasing this because the change in home-manager is not on the latest stable branch (25.05), as you can see for yourself. NixOS 25.11 is expected to be released in a few days, and home-manager should quickly follow and I’ll release a new version with your changes.
There was a problem hiding this comment.
Regarding backward compatibility, I think it should be better to use something like:
default = config.programs.git.userEmail or (lib.attrByPath ["settings" "user" "email"] null config.programs.git);
defaultText = "config.programs.git.userEmail or config.programs.git.settings.user.email";This way, NixKraken supports both methods, since the old config format is deprecated, not removed yet.
Maybe also add a TODO note in the code to remember removing the compat or when old config keys are dropped entirely from home-manager.
There was a problem hiding this comment.
You don't have to update the reference documentation, it's automatically handled in CI 🙂
|
Fair point to hold out till 25.11 is released. I run unstable, so I didn't think about people still running an older release. |
|
Thanks for fixing the format. Don't mind the documentation CI error. I’ll wait for the CI to pass and merge! Thanks again for the fix 🙂 |
Remove build warning, introduced in nix-community/home-manager@aeabc1a
Description
Update the read config values.
Additional Context
Add any other context about the pull request here.
Type of Change
Conventional Type
Scope
Breaking Changes
Warning
If yes, describe impact and migration steps below.
Impact
N/A
Migration Steps
N/A
Related issues
Fixes #
Checklist