Skip to content

chore: update renamed options#25

Merged
nicolas-goudry merged 1 commit intonicolas-goudry:mainfrom
rhoriguchi:main
Nov 28, 2025
Merged

chore: update renamed options#25
nicolas-goudry merged 1 commit intonicolas-goudry:mainfrom
rhoriguchi:main

Conversation

@rhoriguchi
Copy link
Copy Markdown
Contributor

@rhoriguchi rhoriguchi commented Nov 24, 2025

Remove build warning, introduced in nix-community/home-manager@aeabc1a

trace: Obsolete option `programs.git.userEmail' is used. It was renamed to `programs.git.settings.user.email'.
trace: Obsolete option `programs.git.userName' is used. It was renamed to `programs.git.settings.user.name'.

Description

Update the read config values.

Additional Context

Add any other context about the pull request here.

Type of Change

Conventional Type

  • Feature (feat)
  • Bug fix (fix)
  • Chore / Maintenance (chore)
  • Documentation (docs)
  • Refactor (refactor)
  • Performance (perf)
  • Test coverage (test)
  • CI/CD (ci)

Scope

Breaking Changes

  • No
  • Yes
  • Maybe? (Does someone use an old home-manager version?

Warning

If yes, describe impact and migration steps below.

Impact

N/A

Migration Steps

N/A

Related issues

Fixes #

Checklist

  • I ran the test suite locally and it passed
  • I added or updated tests as needed
  • I updated documentation (README, docs site, comments) as needed
  • I verified linting/formatting passes
  • I considered performance implications for large inputs/data sets
  • I added relevant labels, assignees, and reviewers

@cocogitto-bot
Copy link
Copy Markdown

cocogitto-bot Bot commented Nov 24, 2025

✔️ 4042cc7 - Conventional commits check succeeded.

@nicolas-goudry nicolas-goudry self-requested a review November 25, 2025 06:41
@nicolas-goudry nicolas-goudry self-assigned this Nov 25, 2025
Copy link
Copy Markdown
Owner

@nicolas-goudry nicolas-goudry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks for your contribution!

I made some comments on your PR that need to be addressed before considering to merge.

Also, be aware that I’ll hold up on releasing this because the change in home-manager is not on the latest stable branch (25.05), as you can see for yourself. NixOS 25.11 is expected to be released in a few days, and home-manager should quickly follow and I’ll release a new version with your changes.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding backward compatibility, I think it should be better to use something like:

default = config.programs.git.userEmail or (lib.attrByPath ["settings" "user" "email"] null config.programs.git);
defaultText = "config.programs.git.userEmail or config.programs.git.settings.user.email";

This way, NixKraken supports both methods, since the old config format is deprecated, not removed yet.

Maybe also add a TODO note in the code to remember removing the compat or when old config keys are dropped entirely from home-manager.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to update the reference documentation, it's automatically handled in CI 🙂

@rhoriguchi
Copy link
Copy Markdown
Contributor Author

Fair point to hold out till 25.11 is released. I run unstable, so I didn't think about people still running an older release.

@nicolas-goudry
Copy link
Copy Markdown
Owner

Thanks for fixing the format.

Don't mind the documentation CI error.

I’ll wait for the CI to pass and merge!

Thanks again for the fix 🙂

@nicolas-goudry nicolas-goudry merged commit 877c0c3 into nicolas-goudry:main Nov 28, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants