Restart only when extension configuration updated #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I changed
Compare changes of ExtensionConfiguration object and call
extensionController.configurationChangedonly when ExtensionConfiguration is updated.This change includes a refactor of ExtensionConfiguration.
Why
VS Code's ConfigurationChangeEvent is triggered every time when the configuration of workspace updates.
This may cause the unintentional extension restart, for example:
workbench.action.zoomIntriggers this kind of event and the extension restarts when executed by a button-press.Restarts of the extension is necessary when the configuration of the extension, thus this change compares a change of ExtensionConfiguration and trigger restarts only when the extension configuration is updated.
Related issues
fixes #36