Skip to content

allow passing bucket RemovalPolicy #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow passing bucket RemovalPolicy #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/spa-deploy/spa-deploy-construct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { CloudFrontTarget } from '@aws-cdk/aws-route53-targets';
import cdk = require('@aws-cdk/core');
import s3deploy= require('@aws-cdk/aws-s3-deployment');
import s3 = require('@aws-cdk/aws-s3');
import { RemovalPolicy } from '@aws-cdk/core';

export interface SPADeployConfig {
readonly indexDoc:string,
Expand All @@ -28,9 +29,10 @@ export interface SPADeployConfig {
readonly sslMethod?: SSLMethod,
readonly securityPolicy?: SecurityPolicyProtocol,
readonly role?:Role,
readonly bucketRemovalPolicy?: RemovalPolicy,
}

export interface HostedZoneConfig {
export interface HostedZoneConfig extends Partial<SPADeployConfig> {
readonly indexDoc:string,
readonly errorDoc?:string,
readonly cfBehaviors?: Behavior[],
Expand Down Expand Up @@ -92,6 +94,13 @@ export class SPADeploy extends cdk.Construct {
}
}

if (config.bucketRemovalPolicy) {
bucketConfig.removalPolicy = config.bucketRemovalPolicy;
}
if (config.bucketRemovalPolicy === RemovalPolicy.DESTROY) {
bucketConfig.autoDeleteObjects = true;
}

const bucket = new s3.Bucket(this, 'WebsiteBucket', bucketConfig);

if (this.globalConfig.ipFilter === true && isForCloudFront === false) {
Expand Down