Merged
Conversation
Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
… mode switch Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
…scheme mode Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
Fix schema editor: timeline bar gap, extra slot on mode switch, and end-time UX
Owner
|
Thanks for helping out! The refered issue has been open for a while, i had/chose to prioritize other issues.
The checkbox was for end time intended as a feature for users who wanted 1 minute tasks in the same way as with the single mode editor. But I agree that maybe it introduces only confusion and complexity, so maybe its better to remove it indeed. How does your PR handle the toggling between the scheme mode and single mode? Are users able to switch back and forth without the schedule being modified? |
Contributor
Author
Owner
|
Looks good to me. Thanks again! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Using Claude Opus I was able to trace down the issue and fix it.
When in scheme mode, we don't need to be able to uncheck the end time, because the blocks should fill the entire day.
I've tested the changes on 3 systems that I'm administering and everything seems to work.
I'm preparing other PR's, but first I'd like to fix this.
Fixes #946