Skip to content

Option to remove toggle switch + translations cleanup#1109

Merged
nielsfaber merged 11 commits intonielsfaber:mainfrom
Misiu:no_toggle
Mar 14, 2026
Merged

Option to remove toggle switch + translations cleanup#1109
nielsfaber merged 11 commits intonielsfaber:mainfrom
Misiu:no_toggle

Conversation

@Misiu
Copy link
Copy Markdown
Contributor

@Misiu Misiu commented Mar 12, 2026

This adds the requested feature.
image
image

By default, we show the toggles, but the user can explicitly hide them.

I also cleaned up the translations.
New translations are added for new functionality. I also recorded the keys in JSON files based on en.json. For missing keys, we use a fallback from en.json.

The next step is to create a workflow that would periodically check all translations and would reformat/reorder them, add new keys, and remove unused ones.

Closes: #1106

Copilot AI and others added 5 commits March 12, 2026 05:51
Initial plan
50e0eb2
@Misiu
Add show_toggle_switches option to hide per-scheduler toggle switches
ac881d5 
Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
@Misiu
Plan: translate show_toggle_switches into all 25 languages
f3baae7 
Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
@Misiu
Translate show_toggle_switches into all 25 languages
a560374 
Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
@Misiu
Merge pull request #2 from Misiu/copilot/add-show-toggle-switches-option
4e9463d 
Add `show_toggle_switches` card option + sync all translations with en.json
@nielsfaber
Copy link
Copy Markdown
Owner

nielsfaber commented Mar 14, 2026

Thanks for implementing this feature and for taking the time to include translations as well.

I'm having trouble reviewing the changes you have made to the translations.
The PR seems to introduces changes to every line of almost every translation file, but this doesn't seem intentionally as I don't see any functional difference.
Perhaps something was changed to the spaces/tabs or line endings.
Could you please review this, such that your PR only touches code that is actually different?

@Misiu
Copy link
Copy Markdown
Contributor Author

Misiu commented Mar 14, 2026

Sure, we can do the translations in a separate PR.

Copilot AI mentioned this pull request Mar 14, 2026
Merged
Copilot AI and others added 5 commits March 14, 2026 06:58
@Misiu
Revert translation cleanup, keep only show_toggle_switches translations
a72eed8 
Co-authored-by: Misiu <1741838+Misiu@users.noreply.github.com>
@Misiu
Revert translation cleanup; add only show_toggle_switches key
f3cc4b2 
Revert translation cleanup; add only show_toggle_switches key
Initial plan
109180f
Merge upstream nielsfaber/scheduler-card:main changes
48f4cfd 
- Sync timeslot editor refactoring (slot width calculation, drag handling)
- Remove end-time checkbox; auto-convert checkpoints when switching to scheme mode
- Fix schema editor bar gap and unexpected new slot on end-time uncheck
- Update dialog/dropdown menus
- Update demonstration GIF

Includes our show_toggle_switches feature on top of upstream changes.
@Misiu
Merge pull request #4 from Misiu/copilot/sync-changes-with-nielsfaber…
79318d4 
…-scheduler-card

Sync upstream nielsfaber/scheduler-card:main
@Misiu
Copy link
Copy Markdown
Contributor Author

Misiu commented Mar 14, 2026

Ok, good to go :)

@nielsfaber
Copy link
Copy Markdown
Owner

nielsfaber commented Mar 14, 2026

Thank you. This PR can be merged now.

@nielsfaber nielsfaber merged commit bd5de2a into nielsfaber:main Mar 14, 2026
2 checks passed
@nielsfaber
Copy link
Copy Markdown
Owner

nielsfaber commented Mar 14, 2026

Note that I do think your translation update contained valuable improvements.
However, as said, also many lines were affected without any change made to them.
If you manage to find a better way to create a PR for this, it is still very much welcomed.
In case you didn't understand what I tried to point out, here's an example (all red/green lines are marked as changed in the PR):
image

@Misiu
Copy link
Copy Markdown
Contributor Author

Misiu commented Mar 14, 2026

Saw that and I fully understand :)
Will create a new PR in a second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to remove toggle switch

3 participants

@Misiu @nielsfaber