Add assembly classifier to uber-jar, publish normal jar
#956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change two dependency jars will be produced instead of the current one. The current uber-jar will now have a `-assembly` suffix on the aretefact. In place of the un-classified jar will be a "thin" jar; one with just the `spark-excel` classes. This change means end-users can avoid pulling in the uber-jar to environments where it may not be suitable, especially considering the uber-jar contains unshaded dependencies. Resolves nightscape#852
|
I'll update the README and CHANGELOG as requested if this change is OK! |
|
The issue is that spark-submit and spark-shell don't support specifying a classifier, which would make the plugin unusable with those two (see #654 (comment)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change two dependency jars will be produced instead of the current one.
The current uber-jar will now have a
-assemblysuffix on the aretefact. In place of the un-classified jar will be a "thin" jar; one with just thespark-excelclasses.This change means end-users can avoid pulling in the uber-jar to environments where it may not be suitable, especially considering the uber-jar contains unshaded dependencies.
Resolves #852