Skip to content

Insulin Management outside ProfilePlugin #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Insulin Management outside ProfilePlugin #3952

wants to merge 14 commits into from

Conversation

@Philoul
Copy link
Contributor

@Philoul Philoul commented Apr 17, 2025

  • New Insulin Plugin
  • Dia tab removed from ProfilePlugin and from PureProfile
  • ProfileSwitch updated to include Insulin Selection
  • Migration updated (from 3.3.2.0 or 3.3.3.0)
  • Tests updated

@olorinmaia
Copy link
Contributor

olorinmaia commented Apr 24, 2025 •
edited
Loading

Hi @Philoul! :)

I tested this PR upon latest dev + AAPSClient and here are some feedback. Also is this PR a replacement for #3853 ?

If the issues below doesn't appear on your end, is there something I need to do before testing this PR than building upon latest dev?

  1. DIA and Insulin doesn't sync to AAPSClient, this Insulin Activity in overview is not working. I'm using NSClientV3 on my testrig.
AAPSClient overview AAPSClient Profile AAPSClient Profile Switch
image image image
  1. I deleted a few insulin templates that seem to be auto-generated, but they are appearing again after a while in AAPS/AAPSClient. I named the template I created Lyumjev, but the marked ones keep re-appearing:
    image

@Philoul
Copy link
Contributor Author

Philoul commented Apr 24, 2025

@olorinmaia Yes, this PR is a new version with Profiles and insulin completely independant.
When you manage a Profile Switch you select profile on one side and insulin on the other side.

This PR is a first step (already very big), and I have 3 additional PR based on this branch:

  • one to include insulin selection into Insulin dialog in overview (this branch also include database synchro for insulin configuration of boluses within database
  • one for NS synchronization (to send/receive insulin included within ProfileSwitch, EffectiveProfileSwitch and boluses through NS)
  • one for Autotune to include insulin selection for AT calculation.

So issue concerning NS synchro should be fixed with another PR.

@Philoul
Copy link
Contributor Author

Philoul commented Apr 27, 2025

@olorinmaia Concerning your second issue, I don't know if it could be a side effect of NS synchro (especially if AAPS version behind source of data is a previous version with dia managed within profile.
Do you have these creation in AAPS version. in AAPSCLIENT version or in both?

The only automatic insulin creation are done in 2 situations:

  • during migration (insulin plugin or default peak is given by previous selected insulin plugin and an new insulin is created for each dia value found within profiles
  • if a profileswitch is received with an unknown insulin (insulin information is included into EffectiveProfileSwitch).

@olorinmaia
Copy link
Contributor

@Philoul I tried disabling NSClient plugin on AAPS and deleted all other profiles and insulin templates. Here is a video of the issue that still persist on my testrig. Seems like insulin template with custom name gets overwritten by "default name".

Can you reproduce this on your end?

https://photos.app.goo.gl/wAtthmf4pn2qM4tg9

@Philoul
Copy link
Contributor Author

Philoul commented May 6, 2025

Thanks, I could reproduce the issue (bug with migration, previous key was not removed properly so migration was done again on each launch) 🙈

@Philoul
Copy link
Contributor Author

Philoul commented May 8, 2025

@olorinmaia Issue fixed with my latest commits
Thanks

This was referenced Jun 5, 2025
Closed
Merged
Philoul added 2 commits June 9, 2025 21:26
@Philoul
Merge remote-tracking branch 'Nightscout/dev' into Todo/InsulinPluginV2
3e66f63
@Philoul
Merge branch 'Todo/FixRemoveComposedKey' into Todo/InsulinPluginV2
90fc56d 
# Conflicts:
#	core/keys/src/main/kotlin/app/aaps/core/keys/interfaces/Preferences.kt
#	implementation/src/main/kotlin/app/aaps/implementation/sharedPreferences/PreferencesImpl.kt
#	wear/src/main/kotlin/app/aaps/wear/sharedPreferences/PreferencesImpl.kt
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

@Philoul
Merge remote-tracking branch 'Nightscout/dev' into Todo/InsulinPluginV2
1fbb459 
# Conflicts:
#	app/src/main/kotlin/app/aaps/MainApp.kt
#	core/ui/src/main/res/values/strings.xml
#	plugins/main/src/test/kotlin/app/aaps/plugins/main/general/smsCommunicator/SmsCommunicatorPluginTest.kt
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

@Philoul Philoul mentioned this pull request Oct 5, 2025
Draft
@Philoul Philoul mentioned this pull request Oct 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Philoul @olorinmaia