Use lower authorization delay to speed up test-ci script by 20%#8362
Open
je-l wants to merge 2 commits intonightscout:devfrom
Open
Use lower authorization delay to speed up test-ci script by 20%#8362je-l wants to merge 2 commits intonightscout:devfrom
je-l wants to merge 2 commits intonightscout:devfrom
Conversation
This reduces test-ci script execution time by about 20%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lib/authorization/index.js module implements throttling for authorization. The test-ci script is using the default delay of 5000ms, which slows down tests. Using the same value as in docs/example-template.env should be sensible.
This change reduces test-ci script execution time from 66.1s to 52.2s on my laptop.