Merged
Conversation
Member
bewest
commented
Mar 1, 2026
bewest
commented
- Don't install optional dependencies. This eliminates incorrectly installing transitive dev dependencies when they are not needed.
- Tweak npm node_modules preparation in docker builds: omits optional dependencies when building for docker across platforms.
- Tweak minimed/share dependencies -- these have also been versioned and re-published with out optional dependencies in their shrinkwrapped packages.
Use npm ci with --omit=optional to skip optional dependencies like fsevents (darwin-only) that were causing build failures on Linux platforms including Heroku and local Docker builds on Mac.
Both bridge packages now have clean shrinkwraps without devDependencies, eliminating the fsevents (darwin-only) entries that caused Heroku build failures.
Node 16 EOL was September 2023. Docker image uses Node 22. Reduces CI matrix from 9 to 6 jobs.
|
This did not fix the build issue in Heroku |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.