Fix Out of Range RMS not converting from mg/dl to mmol/l#8454
Merged
AndyLow91 merged 2 commits intonightscout:wip/next-releasefrom Mar 17, 2026
Merged
Fix Out of Range RMS not converting from mg/dl to mmol/l#8454AndyLow91 merged 2 commits intonightscout:wip/next-releasefrom
AndyLow91 merged 2 commits intonightscout:wip/next-releasefrom
Conversation
AndyLow91
merged commit cb67da5
into
nightscout:wip/next-release
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use entry.sgv (display units) instead of entry.bgValue (always mg/dl)
in the RMS loop so comparisons with options.targetLow/High are in
consistent units. Remove the incorrect post-hoc division by MMOL_TO_MGDL
since RMSTotal is now accumulated in display units directly.