Open
Conversation
…i/v4/setup/owner)
Domain model, service interface, EF entity with tenant scoping, mapper, and DbContext registration with unique index on (SubjectId, MarkKey).
… is set When running in a worktree with a custom domain (e.g. nocturne.test), the gateway now binds to port 443 if available, so the domain works without a port number. Falls back to a dynamic port if 443 is already taken by the main instance.
…m domain is set" This reverts commit e013f24.
# Conflicts: # src/API/Nocturne.API/Controllers/V4/DevOnly/DevAdminController.cs # src/API/Nocturne.API/Middleware/RecoveryModeMiddleware.cs # src/API/Nocturne.API/Middleware/TenantSetupMiddleware.cs # src/API/Nocturne.API/Services/Auth/RecoveryModeCheckService.cs # src/API/Nocturne.API/Services/Auth/RecoveryModeState.cs # src/Core/Nocturne.Core.Contracts/Multitenancy/ITenantService.cs
Replace removed MealCarbIntake type with MealEvent from the generated API client, updating property accesses across meals UI. Fix implicit any types, unused imports, enum-to-string coercion, and QuietHours interface gap. Includes multitenancy redesign merge artifacts and locale updates.
Replace generic Lucide icon wrappers (Radio, Syringe, Droplet, Battery) with AAPS-sourced SVG paths for device events. Add 11 new therapy event icon components (BgCheck, Calibration, ExtendedBolus, Note, Announcement, Activity, ProfileSwitch, QuestionEvent, BolusEvent, CarbsEvent, SiteRotation). Source SVGs stored in static/icons/aaps/ for reference.
…e glucose, server resolution)
Contributor
Preview Container ImagesPublished for commit
This comment is updated on each push to this PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| _logger.LogInformation( | ||
| "Setup: created first owner {SubjectId} ({Username}) for tenant {TenantId}", | ||
| subjectId, request.Username.Trim(), tenant!.Id); |
|
|
||
| _logger.LogInformation( | ||
| "Setup OIDC: created first owner {SubjectId} ({Username}) for tenant {TenantId}", | ||
| subjectId, request.Username.Trim(), tenant!.Id); |
| { | ||
| if (!string.IsNullOrEmpty(error)) | ||
| { | ||
| _logger.LogWarning("Setup OIDC provider returned error: {Error} - {Description}", error, error_description); |
| { | ||
| if (!string.IsNullOrEmpty(error)) | ||
| { | ||
| _logger.LogWarning("Setup OIDC provider returned error: {Error} - {Description}", error, error_description); |
Comment on lines
+456
to
+463
| Response.Cookies.Append("IsAuthenticated", "true", new CookieOptions | ||
| { | ||
| HttpOnly = false, | ||
| Secure = _oidcOptions.Cookie.Secure, | ||
| SameSite = cookieSameSite, | ||
| Path = "/", | ||
| MaxAge = TimeSpan.FromDays(7), | ||
| }); |
|
|
||
| _logger.LogDebug( | ||
| "Upserting coach mark {MarkKey} to status {Status} for subject {SubjectId}", | ||
| markKey, |
| _logger.LogDebug( | ||
| "Upserting coach mark {MarkKey} to status {Status} for subject {SubjectId}", | ||
| markKey, | ||
| status, |
| _logger.LogError( | ||
| ex, | ||
| "Error upserting coach mark {MarkKey} for subject", | ||
| markKey |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+78
to
+81
| var request = new HttpRequestMessage(HttpMethod.Post, $"{authBaseUrl}{EversenseConstants.Endpoints.Token}") | ||
| { | ||
| Content = formContent | ||
| }; |
| var result = await ExecuteWithRetryAsync( | ||
| async () => | ||
| { | ||
| var request = new HttpRequestMessage(HttpMethod.Get, url); |
| // Assert | ||
| ctx.Response.StatusCode.Should().Be(503); | ||
| ctx.Response.Body.Seek(0, SeekOrigin.Begin); | ||
| var body = await new StreamReader(ctx.Response.Body).ReadToEndAsync(); |
|
|
||
| context.Response.StatusCode.Should().Be(503); | ||
| context.Response.Body.Seek(0, SeekOrigin.Begin); | ||
| var body = await new StreamReader(context.Response.Body).ReadToEndAsync(); |
Comment on lines
+239
to
+243
| catch (Exception ex) | ||
| { | ||
| _logger.LogWarning(ex, "Setup owner passkey registration failed"); | ||
| return Problem(detail: "Passkey registration failed during setup", statusCode: 400, title: "Registration Failed"); | ||
| } |
Comment on lines
+60
to
+64
| catch (Exception ex) | ||
| { | ||
| _logger.LogWarning(ex, "Error converting Eversense patient datum"); | ||
| return null; | ||
| } |
Comment on lines
+148
to
+153
| catch (Exception ex) | ||
| { | ||
| _logger.LogError(ex, "[{ConnectorSource}] Error during Eversense sync", ConnectorSource); | ||
| result.Success = false; | ||
| result.Errors.Add($"Sync error: {ex.Message}"); | ||
| } |
| Username = "test@example.com", | ||
| Password = "test-password", | ||
| }), | ||
| new HttpClient(), |
| return Task.FromResult(kvp.Value); | ||
| } | ||
|
|
||
| return Task.FromResult(new HttpResponseMessage(HttpStatusCode.NotFound)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthTokenProviderBaseGlucoseTrendenum (from LoopKit/LoopWorkspace#266)New files
Modified files
ConnectSource.cs— addedEversenseenum valueDataSources.cs— addedEversenseConnectorconstant +IsConnector()updateServiceNames.cs— addedEversenseConnectorconstantConnectorPropertyKey.cs— addedPatientUsernamekeyTest plan
IConnectorInstallerin Aspire