Skip to content

Wip - fix(app): add error stack trace#4344

Draft
mohit-nagaraj wants to merge 7 commits into
nightwatchjs:mainfrom
mohit-nagaraj:issue/4194-stack-fix
Draft

Wip - fix(app): add error stack trace#4344
mohit-nagaraj wants to merge 7 commits into
nightwatchjs:mainfrom
mohit-nagaraj:issue/4194-stack-fix

Conversation

@mohit-nagaraj

Copy link
Copy Markdown

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

fixes: #4194

  • Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@mohit-nagaraj

Copy link
Copy Markdown
Author

For some reason the error stack is not being properly captured with this. Its not the issue of not being passed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show command usage location in new Element API errors.

1 participant