fix Passed assertion messege of assert.ok & assert.not.ok#4359
Open
webermayank wants to merge 1 commit into
Open
fix Passed assertion messege of assert.ok & assert.not.ok#4359webermayank wants to merge 1 commit into
webermayank wants to merge 1 commit into
Conversation
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Passed issue #4307 - Fix static assertions / node assertion messages
Previously the passed message of the assertions were less detailed hence it was hard to know what has actually passed , is it a truthy value or falsy value
after the fix the message is more detailed with correct value
tested with seperately created file with lots of assertion test
await browser.assert.not.ok(false) -- needs to be improved. Instead of the whole block inside (), something simple could be used like: "Testing the value to be not truthy".
await browser.assert.ok(true) -- seems okayish but could be improved
Perfectly working the prebuild example tests
@garg3133 Have a look as this, i would love to make any changes if needed