Fix: Before hook does not run with async callback returning Promise#4380
Open
ac-mmi wants to merge 12 commits into
Open
Fix: Before hook does not run with async callback returning Promise#4380ac-mmi wants to merge 12 commits into
ac-mmi wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In file
_basehook.jshere in this lineconst invocationResult = this.context.invokeMethod(this.key, client, argsCountthey weren'thandling async results properly—if a hook returned a promise. Now, I added a check: if result is a promise, it
then()waits for it and catches any errors. If it’s not a promise, it works the same way as before.Fixes #4379