Skip to content

Svelte component testing#19

Open
harshit-bs wants to merge 12 commits into
nightwatchjs:mainfrom
harshit-bs:feat/svelte-ct
Open

Svelte component testing#19
harshit-bs wants to merge 12 commits into
nightwatchjs:mainfrom
harshit-bs:feat/svelte-ct

Conversation

@harshit-bs

Copy link
Copy Markdown
Member

No description provided.

Comment thread index.d.ts
Comment thread index.js Outdated
Comment thread package.json Outdated
Comment thread src/utils/injectScript.js Outdated
Comment thread index.d.ts Outdated
Comment thread package.json
@harshit-bs

harshit-bs commented Aug 9, 2023

Copy link
Copy Markdown
Member Author

These build failures are occurring due to the importScript command (written for vue), which returns a Selenium WebElement instead of Nightwatch's extended webElement, causing missing methods like find.

cc @vaibhavsingh97

@harshit-bs harshit-bs marked this pull request as ready for review August 10, 2023 08:17
@harshit-bs

harshit-bs commented Aug 10, 2023

Copy link
Copy Markdown
Member Author

Though svelte has written, they support node 14.18.x in their package.json. But in the recent updates, they have used performance (introduced in node v16.0) here and btoa (introduced in node v15.13.0) here which causing error for svelte component tests in node v14. But working fine in node >=16.0

And as discussed we will remove support v14, so I have upgraded node versions in CI workflow only. Let me know if I should add engines in package.json also or we will take this call later.

cc @AutomatedTester

@AutomatedTester

Copy link
Copy Markdown
Member

And as discussed we will remove support v14, so I have upgraded node versions in CI workflow only. Let me know if I should add engines in package.json also or we will take this call later.

Yes please update that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants