Skip to content

Less hardcodec localhost #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikk150 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Less hardcodec localhost #20

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fd13cc
Do not hardcode component rendering url to localhost
mikk150 Aug 4, 2023
8cb3a92
this console.log is not needed
mikk150 Aug 4, 2023
b42bd49
Merge branch 'main' into less-hardcodec-localhost
mikk150 Sep 26, 2024
9fa6048
lets use viteServer protocol then
mikk150 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions nightwatch/commands/launchComponentRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
module.exports = class Command {
async command() {
let launchUrl = '';
const {vite_dev_server, vite_port} = this.client.settings;
let launchUrl = new URL(this.api.globals.launchUrl ?? this.client.settings.launchUrl ?? 'http://localhost:5173');
const { vite_dev_server, vite_port } = this.client.settings;

if (vite_dev_server) {
const port = vite_dev_server.port || 5173;
launchUrl = `http://localhost:${port}`;
} else if (this.api.globals.launchUrl) {
launchUrl = this.api.globals.launchUrl;
launchUrl.port = vite_port || 5173
}

if (global.viteServer) {
const protocol = global.viteServer.config.server.https ? 'https' : 'http';
launchUrl = `${protocol}://localhost:${global.viteServer.config.port}`;
launchUrl.port = global.viteServer.config.port;
const protocol = global.viteServer.config.server.https ? "https" : "http";
launchUrl.protocol = protocol;
}

return this.api.navigateTo(`${launchUrl}/_nightwatch/`);
launchUrl.pathname = '/_nightwatch/';

return this.api.navigateTo(launchUrl.toString());
}
};