Add a script to verify resolutions after package installation #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPARC Vue3 Portal Testing
|
|||||||||||||||||||||||||||||||||||||||||||
| Project |
SPARC Vue3 Portal Testing
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 53m 52s |
| Commit |
|
| Committer | Alan Wu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
0
|
Pending
|
40
|
Skipped
|
0
|
Passing
|
166
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
datasets/imagegallery.cy.js • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| Dataset 385 > Viewer > Image |
Test Replay
Screenshots
|
|
| Dataset 226 > Viewer > Image |
Test Replay
Screenshots
|
|
homepage.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Homepage > Find by |
Test Replay
Screenshots
|
|
alan-wu
approved these changes
Dec 18, 2025
Contributor
alan-wu
left a comment
alan-wu
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a strict version check to prevent incompatibility issues with
@abi-software/flatmapvuer. Currently, Yarnresolutionsonly output a warning during installation if versions do not match. These warnings are easily missed.Changes
"@abi-software/flatmapvuer": "1.12.1"inresolutions.postinstallscript (verify-resolutions.js) that converts resolution warnings into fatal errors.@abi-software/flatmapvuer.PACKAGES_TO_CHECKvariable in the script.Note
If there is an updated version of
@abi-software/flatmapvuer, we have to update its version inresolutions.Related issue: https://github.com/nih-sparc/sparc-app-issues/issues/500