Sparc header #11
Open
Sparc header #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egauzens
approved these changes
Dec 6, 2023
Collaborator
egauzens
left a comment
egauzens
left a comment
There was a problem hiding this comment.
Yeah I like that idea, just merge it in and i can have a look from main. It's not a big deal because right now we are using the original header in the app still so I can take a look at it further down the road
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a weird linking things with the header that I think are related to vue-router not being fully set up. So not sure if it's actually broken.
I figured I could merge into main since it's not a deployed repo. That way you can look at it easier.
but I added a handful of icons with this branch, so that will be useful.