Fix cluster test #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rustls](https://github.com/rustls/rustls) from 0.23.4 to 0.23.5. - [Release notes](https://github.com/rustls/rustls/releases) - [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md) - [Commits](rustls/rustls@v/0.23.4...v/0.23.5) --- updated-dependencies: - dependency-name: rustls dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.116 to 1.0.117. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.116...v1.0.117) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rustls-pemfile](https://github.com/rustls/pemfile) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/rustls/pemfile/releases) - [Commits](rustls/pemfile@v/2.1.1...v/2.1.2) --- updated-dependencies: - dependency-name: rustls-pemfile dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [num-bigint](https://github.com/rust-num/num-bigint) from 0.4.4 to 0.4.5. - [Changelog](https://github.com/rust-num/num-bigint/blob/master/RELEASES.md) - [Commits](rust-num/num-bigint@num-bigint-0.4.4...num-bigint-0.4.5) --- updated-dependencies: - dependency-name: num-bigint dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tokio-util](https://github.com/tokio-rs/tokio) from 0.7.10 to 0.7.11. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-util-0.7.10...tokio-util-0.7.11) --- updated-dependencies: - dependency-name: tokio-util dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.9.0 to 3.10.1. - [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md) - [Commits](Stebalien/tempfile@v3.9.0...v3.10.1) --- updated-dependencies: - dependency-name: tempfile dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ryu](https://github.com/dtolnay/ryu) from 1.0.17 to 1.0.18. - [Release notes](https://github.com/dtolnay/ryu/releases) - [Commits](dtolnay/ryu@1.0.17...1.0.18) --- updated-dependencies: - dependency-name: ryu dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [rustls](https://github.com/rustls/rustls) from 0.23.5 to 0.23.8. - [Release notes](https://github.com/rustls/rustls/releases) - [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md) - [Commits](rustls/rustls@v/0.23.5...v/0.23.8) --- updated-dependencies: - dependency-name: rustls dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.199 to 1.0.203. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.199...v1.0.203) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.37.0 to 1.38.0. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.37.0...tokio-1.38.0) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
nihohit
force-pushed
the
fix-cluster-test
branch
2 times, most recently
from
8964822 to
9cf1d8b
Compare
* Add max retry delay for every reconnect * Update comment docs * Refactor code, make ConnectionConfigInfo include retry&timeout * Update code from feedback * Update test * Update docs * Update docs * Fix build * Remove comment in test * Fix lint when build * Fix build
In cases where `T: ToOwned, &T: ToRedisArgs, &T::Owned: ToRedisArgs` we can implement `ToRedisArgs` for `Cow<'_, T>` by delegating to the inner implementations. This gives support for `Cow<[u8]>` and `Cow<str>` out of the box, and allows downstream consumers to get `Cow<Newtype>` implementations for free, without needing to `match` in their code. An alternative implementation would be to always call `Cow::as_ref`, which would relax the bound of `&T::Owned: ToRedisArgs`, but in cases where the implementation of `ToRedisArgs` is specialized for `&T::Owned` this is suboptimal. As an example, see [`String::as_bytes`][1] vs [`String::as_str`][2] followed by [`str::as_bytes`][3]; by using the specialized implementation of `String::to_redis_args`, we save some overhead. [1]: https://doc.rust-lang.org/std/string/struct.String.html#method.as_bytes [2]: https://doc.rust-lang.org/std/string/struct.String.html#method.as_str [3]: https://doc.rust-lang.org/std/primitive.str.html#method.as_bytes
This allows us to find errors that aren't visible in stdout/stderr.
This issue happens often when I ran the tests locally on my MacOS machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.