Period Stream Filter & Bugfix Inverse Logic #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lollolong
changed the title
nilaoda
force-pushed
the
main
branch
2 times, most recently
from
d1bea34 to
e53faf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option to drop streams based on the period name, this can be useful to drop ads which got injected into the mpd.
Sample:
<Period id="ad-bumper-0-0" duration="PT5.005S" start="PT0.000S">While adding this option I've noticed a bug - the dropping of streams isn't working properly. I like the approach how it was initially designed to select the streams using
DoFilterKeep()and then inversing the selection, however this wont work if I specify multiple criteria's.In my case:
--drop-audio role=Description:period=ad-bumper:for=allThe logic is searching for streams with role "Description" AND period "ad-bumper". It wont find any streams and ends up doing nothing.
I copied the
DoFilterKeep()intoDoFilterDrop()and inversed now every condition. A bit more code but works now correct.