-
Notifications
You must be signed in to change notification settings - Fork 63
feat: allow chunkwise training and limit the number of processes for AFHMM+SAC #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
levaphenyl
wants to merge
9
commits into
nilmtk:master
Choose a base branch
from
levaphenyl:NILMTK-CONTRIB-36
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8903ad
to
be8c383
Compare
This was referenced Oct 7, 2020
59e919e
to
c0e8ad2
Compare
c0e8ad2
to
2326bce
Compare
…the constraints setup and the actual minimization
2326bce
to
a0610f4
Compare
Having a quick scan through the code, this seems reasonably complete. Any blockers for merging? |
@jonnor - Thank you for your interest! The only blocker is to prove that the new code works as well as the former one. Unfortunately, I don't have time to test it these days. Would you like to try on your machine and report, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36
Fixes: #40
Fixes: #42
Fixes: #27
Tested on UK-DALE.

TODO: dev-test both AFHMM & AFHMM+SAC