Skip to content

clean up imports in system #25355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ringabout wants to merge 13 commits into
base: devel
Choose a base branch
from
Open

clean up imports in system #25355

ringabout wants to merge 13 commits into from

Conversation

@ringabout
Copy link
Member

@ringabout ringabout commented Dec 16, 2025 •
edited
Loading

ref #24272

  • removes all exported symbols
  • adds Dr suffixes for most symbols in dragonbox because these names conflict with schubfach

@ringabout ringabout changed the title clean up imports in system clean up imports in system Part I Dec 16, 2025
@ringabout
Copy link
Member Author

ringabout commented Dec 16, 2025

breaks hcr somehow :( D:\a\1\s\nimcache\tests\dll\[email protected]:627:33: error: incompatible types when assigning to type 'TNimTypeV2 *' from type 'TNimTypeV2'
2025-12-16T13:17:02.9031384Z 627 | (*T1_).Sup.Sup.Sup.Sup.m_type = (NTIv2__Nb1QpIzoQAo7kn8Y2saslA_);

@arnetheduck
Copy link
Contributor

arnetheduck commented Dec 16, 2025

breaks hcr somehow

why not just remove hcr?

@ringabout
Copy link
Member Author

ringabout commented Dec 16, 2025

After investigation, it seems that switching to include system/exceptions breaks nimhcr

@ringabout ringabout changed the title clean up imports in system Part I clean up imports in system Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ringabout @arnetheduck