Skip to content

fixes #22791; ProveField warning with nested case object #25774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ringabout wants to merge 1 commit into
base: devel
Choose a base branch
from
+23 −1
Open

fixes #22791; ProveField warning with nested case object #25774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/guards.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ proc isLocation(n: PNode): bool = not n.isValue

proc isLet(n: PNode): bool =
if n.kind == nkSym:
if n.sym.kind in {skLet, skTemp, skForVar}:
if n.sym.kind in {skLet, skConst, skTemp, skForVar}: # guard immutable variables
result = true
elif n.sym.kind == skParam and skipTypes(n.sym.typ,
abstractInst).kind notin {tyVar}:
Expand Down
22 changes: 22 additions & 0 deletions tests/objvariant/tcorrectcheckedfield.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,25 @@ block: # issue #24021
discard
else:
discard foo.z


# bug #22791
type Foo = object
case a: bool
of false:
discard
of true:
case b: bool
of false:
discard
of true:
c: bool

const f = Foo(a: true, b: true, c: true)
case f.a
of true:
case f.b
of true:
echo f.c
Comment thread
ringabout marked this conversation as resolved.
else: discard
else: discard