fixes #22861; Error: internal error: invalid kind for lastOrd(tyGenericParam)#25776
Open
fixes #22861; Error: internal error: invalid kind for lastOrd(tyGenericParam)#25776
Conversation
…icParam) Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Nim compiler crash #22861 triggered by overload resolution involving a generic array parameter and a concrete typedesc[array[...]] overload.
Changes:
- Adjusts
typeRel’styArraymatching to correctly track the relation result for the array index type and to bind/use the actual index type (aRange) instead of the whole array type. - Ensures an index-type match that is only
isGenericcan’t incorrectly “upgrade” the overall array match toisEqual. - Adds a regression test covering the reported overloaded generic
fromHexscenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
compiler/sigmatch.nim |
Fixes array index-type matching/binding in typeRel to prevent mis-ranking/incorrect handling that led to the internal error. |
tests/generics/tgenerics_various.nim |
Adds a compile regression case for #22861 (overloaded generic procs with array + typedesc[array[...]]). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22861