Skip to content

fix: package version detection for usernames with digits #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
levovix0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: package version detection for usernames with digits #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/basic/versions.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,9 +560,12 @@ proc parseTaggedVersions*(outp: string, requireVersions = true): seq[VersionTag]
peeled = true
refName = refName[0..^4]

# parse version from last path component to avoid false matches on digits in usernames
let lastSlash = refName.rfind('/')
let tagPart = if lastSlash >= 0: refName.substr(lastSlash + 1) else: refName
var j = 0
while j < refName.len and refName[j] notin Digits: inc j
let v = parseVersion(refName, j)
while j < tagPart.len and tagPart[j] notin Digits: inc j
let v = parseVersion(tagPart, j)
let c = initCommitHash(line.substr(0, commitEnd-1), FromGitTag)
if c.isEmpty() or (v == Version("") and requireVersions):
continue
Expand Down
Loading