Warn missmatch (#1533)

* Warns when there is a missmatch between the tag and the nimble file
version

* Improves comment

Author: jmgomez

src/nimble.nim

@@ -2691,6 +2691,16 @@ proc runVNext*(options: var Options, nimBin: string) {.instrument.} =
   # options.debugSATResult()
   options.satResult.addReverseDeps(options)
 
+  # Warn about version mismatches for packages in the solution
+  # Compare installed version (from directory/tag) with the version in the .nimble file
+  for pkgInfo in options.satResult.pkgs:
+    try:
+      let nimbleFileInfo = extractRequiresInfo(pkgInfo.myPath, options)
+      if nimbleFileInfo.version != "" and newVersion(nimbleFileInfo.version) != pkgInfo.basicInfo.version:
+        displayWarning(&"Version mismatch for {pkgInfo.basicInfo.name}: installed version is {pkgInfo.basicInfo.version} but .nimble file declares {nimbleFileInfo.version}.", HighPriority)
+    except CatchableError:
+      discard 
+  
 proc getNimDir(options: var Options, nimBin: string): string = 
   ## returns the nim directory prioritizing the nimBin one if it satisfais the requirement of the project
   ## otherwise it returns the major version of the nim installed packages that satisfies the requirement of the project

src/nimblepkg/vnext.nim

@@ -665,12 +665,11 @@ proc installFromDirDownloadInfo(nimBin: string,downloadDir: string, url: string,
   var depsOptions = options
   depsOptions.depsOnly = false
 
-  # Check for version mismatch between tag and .nimble file
-  # If SAT solver expects a specific version but .nimble has different version,
-  # the package maintainer likely forgot to update their .nimble file
-  # TODO in a subsequent PR this will improved so we keep track of the mismatch in PkgInfo
+  # Check for version mismatch between git tag and .nimble file
+  # pv.ver.ver is the version from the SAT solver, which was discovered from git tags
+  # (e.g., tag v0.36.0 -> version 0.36.0). If the .nimble file declares a different
+  # version (e.g., 0.1.0), we use the tag version since that's what was requested.
   if pv.ver.kind == verEq and pkgInfo.basicInfo.version != pv.ver.ver:
-    displayWarning(&"Version mismatch for {pkgInfo.basicInfo.name}: tag has {pv.ver.ver} but .nimble file has {pkgInfo.basicInfo.version}. Using tag version.", HighPriority)
     pkgInfo.basicInfo.version = pv.ver.ver
 
   display("Installing", "$1@$2" %