feat(#1450): add --skipBin to limit compilation of hybrid deps#1647
feat(#1450): add --skipBin to limit compilation of hybrid deps#1647daylinmorgan wants to merge 8 commits into
Conversation
IMO when Wether to approve this or not, it isnt my call. cc @Araq @arnetheduck |
I agree, this make more sense, and is certainly how I would imagine users would expect it to work. |
8a8be35 to
e7299ba
Compare
ac9381b to
1883245
Compare
unrelated test failures were triggered by a missing nim to execute nimscript to downgrade a removed package
| let binPath = pkgInfo.getOutputDir(bin) | ||
| if not fileExists(binPath): | ||
| return false | ||
| result = true |
| cleanFiles nimblePathsFileName, nimbleConfigFileName | ||
| body | ||
|
|
||
| suite "--skipBin": |
There was a problem hiding this comment.
Please dont use templates to expand the tests, its fine to extract repeated code but this doesnt follow the symmetry of the whole codebase. Try to be more meaningful in the suite name
There was a problem hiding this comment.
I thought at least one template would be necessary to abstract the repeated step (checkSkip in this case) when using std/unittest since otherwise the check false isn't propagated to the test block level and then the test itself shows as [OK] even with failures.
This implements a new flag
--skipBin, so that we can runnimble build|setup|installwithout also compiling hybrid dependencies.In the current implementation, subsequent runs don't attempt to compile the binary for example:
nimble setup --skipBin && nimble setupdoesn't result in hybrid dep binaries being compiled.I'm not sure if that is what we want, let me know if any invocation without
--skipBinshould result in compilation of the hybrid deps. In which case I think I need to adjust the heuristics insolveLockFileDeps.Closes #1450